Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: linking with cc failed #128894

Closed
BoxyUwU opened this issue Aug 9, 2024 · 3 comments
Closed

regression: linking with cc failed #128894

BoxyUwU opened this issue Aug 9, 2024 · 3 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@BoxyUwU
Copy link
Member

BoxyUwU commented Aug 9, 2024

@BoxyUwU BoxyUwU added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Aug 9, 2024
@rustbot rustbot added I-prioritize Issue: Indicates that prioritization has been requested for this issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Aug 9, 2024
@BoxyUwU BoxyUwU removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Aug 9, 2024
@bjorn3
Copy link
Member

bjorn3 commented Aug 10, 2024

Looks like this crate is depending on two different version of wit-bindgen-rust. Both should define the same unmangled symbol, and as such a linker error is expected.

[INFO] [stderr]    Compiling wit-bindgen-rust v0.1.0 (https://github.com/bytecodealliance/wit-bindgen?rev=e9c7c0a3405845cecd3fe06f3c20ab413302fc73#e9c7c0a3)
[INFO] [stderr]    Compiling wit-bindgen-rust v0.1.0 (https://github.com/bytecodealliance/wit-bindgen?rev=2f46ce4cc072107153da0cefe15bdc69aa5b84d0#2f46ce4c)

@apiraino
Copy link
Contributor

Is this crate in a shape to still be relevant to our crater runs? 🤔

I see a slew of warnings when trying to compile it from clean slate (i.e. installing the needed toolchains)

@bjorn3
Copy link
Member

bjorn3 commented Aug 12, 2024

It also depends on an outdated wit-bindgen version which I'm not sure will work with current component model implementations.

@BoxyUwU BoxyUwU closed this as completed Sep 18, 2024
@apiraino apiraino removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants