Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-url's debugger_visualizer tests are broken in rustc nightly-2024-08-13 #130431

Closed
valenting opened this issue Sep 16, 2024 · 4 comments
Closed
Labels
C-discussion Category: Discussion or questions that doesn't represent real issues. WG-debugging Working group: Bad Rust debugging experiences

Comments

@valenting
Copy link

I was looking into servo/rust-url#967 but I wasn't able to reproduce the failures locally. Then I realized I was running an older nightly.

I used bisect-rustc and got the following output:


searched nightlies: from nightly-2024-08-01 to nightly-2024-09-16
regressed nightly: nightly-2024-08-13
searched commit range: 41dd149...91376f4
regressed commit: 13f8a57

bisected with cargo-bisect-rustc v0.6.9

Host triple: x86_64-pc-windows-msvc
Reproduce with:

cargo bisect-rustc --start=2024-08-01 --end=2024-09-16 --test-dir=rust-url -- test --test debugger_visualizer --features url/debugger_visualizer,url_debug_tests/debugger_visualizer -- --test-threads=1 --nocapture

The PR that introduced the issue seems to be: #126793

Example failing job: https://github.com/servo/rust-url/actions/runs/10879435038/job/30184131451

@valenting valenting added C-bug Category: This is a bug. regression-untriaged Untriaged performance or correctness regression. labels Sep 16, 2024
@rustbot rustbot added I-prioritize Issue: Indicates that prioritization has been requested for this issue. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Sep 16, 2024
@jieyouxu jieyouxu added the WG-debugging Working group: Bad Rust debugging experiences label Sep 16, 2024
@jieyouxu
Copy link
Member

cc @saethlin since you authored #126793 and are more familiar with debuggers

@jieyouxu jieyouxu added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Sep 16, 2024
@saethlin saethlin added E-needs-mcve Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example C-discussion Category: Discussion or questions that doesn't represent real issues. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-bug Category: This is a bug. E-needs-mcve Call for participation: This issue has a repro, but needs a Minimal Complete and Verifiable Example I-prioritize Issue: Indicates that prioritization has been requested for this issue. regression-untriaged Untriaged performance or correctness regression. needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Sep 16, 2024
@saethlin
Copy link
Member

The issue is that you need to update your natvis file for the new level of nesting in Vec, probably this line:
https://github.com/servo/rust-url/blob/22b823708a59a50ea2505c3fcdb5c4b26ab9b080/debug_metadata/url.natvis#L4

You could use the changes to our own natvis file in that PR you bisected to as a guide.

I've removed the regression and bug labels, because (unfortunately) doing cool debugger stuff like this means you are depending on unstable library internals. If only we could teach debuggers how to go through our stable APIs to get the information 🙃

@valenting
Copy link
Author

@saethlin thank you for the suggestion. Very much appreciated!
Feel free to close this bug.

@jieyouxu
Copy link
Member

Closing as unfortunately not super actionable in terms of rustc/std.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-discussion Category: Discussion or questions that doesn't represent real issues. WG-debugging Working group: Bad Rust debugging experiences
Projects
None yet
Development

No branches or pull requests

4 participants