-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rust-url's debugger_visualizer tests are broken in rustc nightly-2024-08-13 #130431
Comments
The issue is that you need to update your natvis file for the new level of nesting in Vec, probably this line: You could use the changes to our own natvis file in that PR you bisected to as a guide. I've removed the regression and bug labels, because (unfortunately) doing cool debugger stuff like this means you are depending on unstable library internals. If only we could teach debuggers how to go through our stable APIs to get the information 🙃 |
@saethlin thank you for the suggestion. Very much appreciated! |
Closing as unfortunately not super actionable in terms of rustc/std. |
I was looking into servo/rust-url#967 but I wasn't able to reproduce the failures locally. Then I realized I was running an older nightly.
I used bisect-rustc and got the following output:
searched nightlies: from nightly-2024-08-01 to nightly-2024-09-16
regressed nightly: nightly-2024-08-13
searched commit range: 41dd149...91376f4
regressed commit: 13f8a57
bisected with cargo-bisect-rustc v0.6.9
Host triple: x86_64-pc-windows-msvc
Reproduce with:
cargo bisect-rustc --start=2024-08-01 --end=2024-09-16 --test-dir=rust-url -- test --test debugger_visualizer --features url/debugger_visualizer,url_debug_tests/debugger_visualizer -- --test-threads=1 --nocapture
The PR that introduced the issue seems to be: #126793
Example failing job: https://github.com/servo/rust-url/actions/runs/10879435038/job/30184131451
The text was updated successfully, but these errors were encountered: