Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NestedMetaItem would be better named as MetaItemInner #131087

Closed
Urgau opened this issue Oct 1, 2024 · 2 comments · Fixed by #131235
Closed

NestedMetaItem would be better named as MetaItemInner #131087

Urgau opened this issue Oct 1, 2024 · 2 comments · Fixed by #131235
Assignees
@codemountains
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Urgau
Copy link
Member

Urgau commented Oct 1, 2024 •
edited by rustbot
Loading

An aside: NestedMetaItem would be better named as MetaItemInner, to match the grammar.

Originally posted by @nnethercote in #131034 (comment)
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Oct 1, 2024
@Urgau Urgau added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. C-cleanup Category: PRs that clean code up or issues documenting cleanup. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Oct 1, 2024
@Urgau Urgau mentioned this issue Oct 1, 2024
Merged
@codemountains
Copy link
Contributor

Hi. I'm also interested in this issue as the first time for contribution to rust!

@rustbot claim

@nnethercote
Copy link
Contributor

@codemountains: when you create the pull request, feel free to write "r? @nnethercote" to request review from me.

@rust-lang rust-lang deleted a comment from rustbot Oct 1, 2024
@codemountains codemountains mentioned this issue Oct 4, 2024
Merged
@bors bors closed this as completed in 0b16baa Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codemountains codemountains

Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename NestedMetaItem to MetaItemInner codemountains/rust
4 participants
@nnethercote @Urgau @rustbot @codemountains