Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dont-check-error-annotations to compiletest #132647

Open
BoxyUwU opened this issue Nov 5, 2024 · 1 comment
Open

Add a dont-check-error-annotations to compiletest #132647

BoxyUwU opened this issue Nov 5, 2024 · 1 comment
Labels
A-compiletest Area: The compiletest test runner C-feature-request Category: A feature request, i.e: not implemented / a PR. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@BoxyUwU
Copy link
Member

BoxyUwU commented Nov 5, 2024

cc @jieyouxu

It would be nice if compiletest could support a //@ dont-check-error-annotations annotation that would not require you to annotate your file with //~^ ERROR: anywhere. This would be useful for cases where I only care that the test doesn't start ICEing. Ideally we'd never need this but sometimes I wind up with hundreds of errors with useless spans and it's just not realistic (or helpful) to annotate it all. See for example this test, all the error annotations are in the wrong place as macro diagnostics emit the error on the macro definition not the caller. This means that we'd wind up with ~100 error annotations on the insides of the macros which is not a helpful assertion whatsoever.

@BoxyUwU BoxyUwU added A-compiletest Area: The compiletest test runner C-feature-request Category: A feature request, i.e: not implemented / a PR. labels Nov 5, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Nov 5, 2024
@BoxyUwU BoxyUwU added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) and removed needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. labels Nov 5, 2024
@jieyouxu
Copy link
Member

Somewhat related is also #46667.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-compiletest Area: The compiletest test runner C-feature-request Category: A feature request, i.e: not implemented / a PR. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

3 participants