Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compiletest: 'known directive' check does not account for suites #134739

Closed
clubby789 opened this issue Dec 25, 2024 · 3 comments
Closed

compiletest: 'known directive' check does not account for suites #134739

clubby789 opened this issue Dec 25, 2024 · 3 comments
Labels
A-compiletest Area: The compiletest test runner A-test-infra Area: test infrastructure (may span bootstrap/compiletest/more) C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@clubby789
Copy link
Contributor

#134738

A few UI tests uses 'forbid-output' despite it (currently) only working for incremental tests. This is because the known directive check doesn't account for the supported suites; this makes me suspect there might be a few more noop directives in our test suite

@clubby789 clubby789 added A-compiletest Area: The compiletest test runner A-test-infra Area: test infrastructure (may span bootstrap/compiletest/more) C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Dec 25, 2024
@rustbot rustbot added the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Dec 25, 2024
@clubby789 clubby789 removed the needs-triage This issue may need triage. Remove it if it has been sufficiently triaged. label Dec 25, 2024
@jieyouxu
Copy link
Member

It's less noop directive in general, it's moreso that most(?) directives are only supported for a subset of test suites. The known directive check is a very crude and stopgap way to block new unknown (like, at all) directives from being added, but does not try to fix the preexisting problem of a directive being unsupported in certain suites.

@jieyouxu
Copy link
Member

Part of #131425.

Anyway, I think we should fix this by having directive registration explicitly declare what test suites they do support.

@clubby789
Copy link
Contributor Author

Closing in favour of #128058

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-compiletest Area: The compiletest test runner A-test-infra Area: test infrastructure (may span bootstrap/compiletest/more) C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
Development

No branches or pull requests

3 participants