Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No SyntaxExtension variant can modify foreign items #27126

Closed
tomjakubowski opened this issue Jul 19, 2015 · 3 comments
Closed

No SyntaxExtension variant can modify foreign items #27126

tomjakubowski opened this issue Jul 19, 2015 · 3 comments
Labels
A-syntaxext Area: Syntax extensions C-feature-request Category: A feature request, i.e: not implemented / a PR.

Comments

@tomjakubowski
Copy link
Contributor

SyntaxExtension::MultiModifier only visits true items, ImplItems, and TraitItems, not ForeignItems. This makes it impossible to write syntax extensions which operate directly on foreign items (e.g. functions declared inside an extern block).

I started work on rust-lang/rfcs#1217 out of tree but hit this issue almost right away.
@steveklabnik steveklabnik added the A-syntaxext Area: Syntax extensions label Jul 20, 2015
@steveklabnik
Copy link
Member

Triage: this bit still exists.

@Mark-Simulacrum Mark-Simulacrum added C-bug Category: This is a bug. C-feature-request Category: A feature request, i.e: not implemented / a PR. and removed C-bug Category: This is a bug. labels Jul 22, 2017
@steveklabnik
Copy link
Member

Triage: this still exists, but syntax extensions are never being stabilized as a public api, and there's been no real comments since this issue has been opened. I'm going to close this as WONTFIX. If you really truly care about this still please let me know!

@petrochenkov
Copy link
Contributor

This was actually fixed in #49350

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-syntaxext Area: Syntax extensions C-feature-request Category: A feature request, i.e: not implemented / a PR.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@steveklabnik @tomjakubowski @Mark-Simulacrum @petrochenkov