-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panic caused by Markdown in latest nightly #40918
Comments
The problem is that this block:
Is considered as code. I wonder what would be a good solution for this (because that's how correct markdown considers this)... |
I don't think it should be...should it? It wasn't prior to this: https://api.rocket.rs/rocket/request/trait.FromFormValue.html#provided-implementations |
Yes but before, hoedown wasn't really markdown compliant. You can see by yourself how your code is interpreted by the markdown here. |
(not giving this all the tags because it's linked in to the tracking issue |
To be clear, this is a test failure, not an ICE, correct? thread 'rustc' panicked at 'couldn't compile the test', /checkout/src/librustdoc/test.rs:270 that is, this is a test failure. |
Yes. |
Right. So this is more of expected breakages caused by a bugfix. @SergioBenitez are you running off rustc master? I wasn't even aware this was in nightly yet, I thought it missed the cutoff. As I mentioned in the other issue, I was planning on publicizing this tomorrow. |
@steveklabnik Looks like this made it into today's nightly. Okay, so after discussing this a bit on IRC and playing with the Leading text:
* List Item Heading
This is considered to be part of the list item in `hoedown` but not `pulldown-cmark`.
This is still inside the list item in `hoedown` but is a new code block in `pulldown-cmark`. As shown above, text that While this isn't a bug in |
Huh. Well, better make that post for sure, I guess. (The nightly) Crater wouldn't catch this, it doesn't run tests. |
Should work. The prior behaviour seems like a bug to me even considering the original markdown, and I think this is not easily fixable without making the markdown parser non-compliant. |
I'm giving this one a close since it's expected behavior. Thanks all! |
rustc
is panicking on markdown that previously parsed. This appears to be caused by the transition from hoedown to pulldown-cmark (#40912, #40338):The markdown being referenced in the error looks like this:
cc @steveklabnik @GuillaumeGomez
The text was updated successfully, but these errors were encountered: