Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust 1.19 regression, sliding_windows 2.0.3 #42464

Closed
brson opened this issue Jun 6, 2017 · 3 comments
Closed

Rust 1.19 regression, sliding_windows 2.0.3 #42464

brson opened this issue Jun 6, 2017 · 3 comments
Labels
regression-from-stable-to-nightly Performance or correctness regression from stable to nightly.

Comments

@brson
Copy link
Contributor

brson commented Jun 6, 2017

https://github.com/flo-l/rust-sliding_windows

brian@ip-10-145-43-250:~/dev/slate/rust-sliding_windows⟫ git log -1
commit ff627b0757a43c219d34d888e7705e9570ff904a
Author: flo-l <lacknerflo@gmail.com>
Date:   Thu Mar 17 15:53:32 2016 +0100

    update README

brian@ip-10-145-43-250:~/dev/slate/rust-sliding_windows⟫ cargo +nightly test
   Compiling sliding_windows v2.0.3 (file:///mnt2/dev/slate/rust-sliding_windows)
    Finished dev [unoptimized + debuginfo] target(s) in 1.22 secs
     Running target/debug/deps/sliding_windows-5ae024d63933df5e

running 6 tests
test tests::sliding_windows_2 ... ok
test tests::sliding_windows_1 ... ok
test tests::sliding_windows_3 ... ok
test tests::sliding_windows_5 ... ok
test tests::sliding_windows_6 ... ok
test tests::sliding_windows_4 ... FAILED

failures:

---- tests::sliding_windows_4 stdout ----
        thread 'tests::sliding_windows_4' panicked at 'assertion failed: `(left == right)` (left: `(18446744073709551610, None)`, right: `(0, None)`)', src/tests.rs:72


failures:
    tests::sliding_windows_4

test result: FAILED. 5 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out

error: test failed, to rerun pass '--lib'

cc @flo-l

@brson brson added the regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. label Jun 6, 2017
@Mark-Simulacrum
Copy link
Member

e0cc22b -- rollup #42336; #42315 which I believe makes this an intentional change.

@flo-l
Copy link
Contributor

flo-l commented Jun 7, 2017

my test was wrongly assuming this, fixed by flo-l/rust-sliding_windows@1bf7488

@flo-l
Copy link
Contributor

flo-l commented Jun 7, 2017

@brson thanks for the heads-up, this issue is resolved and can be closed! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-nightly Performance or correctness regression from stable to nightly.
Projects
None yet
Development

No branches or pull requests

4 participants