Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github's license detection is messed up #43188

Closed
steveklabnik opened this issue Jul 12, 2017 · 8 comments
Closed

Github's license detection is messed up #43188

steveklabnik opened this issue Jul 12, 2017 · 8 comments
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-core Relevant to the core team, which will review and decide on the PR/issue.

Comments

@steveklabnik
Copy link
Member

https://github.com/rust-lang/rust/community links to https://github.com/rust-lang/rust/blob/master/COPYRIGHT

The docs don't make any mention of looking for COPYRIGHT.

#39897 suggests re-writing COPYRIGHT anyway.

I'd argue that we should

  1. Remove the COPYRIGHT file.
  2. replace it with a LICENSE.md file
  3. The contents of such should point to our other license files.

This would not totally solve #39897, but it's a start. Hence this separate ticket.

What do you think, @rust-lang/core ?
@steveklabnik steveklabnik added A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools T-core Relevant to the core team, which will review and decide on the PR/issue. labels Jul 12, 2017
@est31
Copy link
Member

est31 commented Jul 12, 2017

Github doesn't support dual licenses, so if we'd get it to display a license, it'd be not accurate. eg https://github.com/steveklabnik/rustdoc shows up as "Apache-2.0". I'm not sure whether that's wanted.

@est31
Copy link
Member

est31 commented Jul 12, 2017

As the missing support for dual licenses affects many official and unofficial rust projects, it might be something to contact Github about.

@codyps
Copy link
Contributor

codyps commented Jul 12, 2017

https://github.com/blog/1964-open-source-license-usage-on-github-com

To detect what license, if any, a project is licensed under, we used an open source Ruby gem called Licensee

@steveklabnik
Copy link
Member Author

eg https://github.com/steveklabnik/rustdoc shows up as "Apache-2.0".

heh yeah I wanted to tackle that after I tackle this.

Oh thanks @jmesmon !

@steveklabnik
Copy link
Member Author

cc licensee/licensee#203

@steveklabnik
Copy link
Member Author

also cc licensee/licensee#114 (comment)

@daira daira mentioned this issue Jul 17, 2017
Closed
@Mark-Simulacrum Mark-Simulacrum added C-question C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC and removed C-question labels Jul 28, 2017
@frewsxcv
Copy link
Member

GitHub no longer incorrectly reports this repo as Apache-2.0. Should we fold this issue into #39897 ?

@steveklabnik
Copy link
Member Author

Yup!

@frewsxcv frewsxcv mentioned this issue Dec 2, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools C-tracking-issue Category: An issue tracking the progress of sth. like the implementation of an RFC T-core Relevant to the core team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@steveklabnik @codyps @frewsxcv @Mark-Simulacrum @est31