Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support all formatting flags in std::path::Display #44048

Closed
alexcrichton opened this issue Aug 22, 2017 · 3 comments
Closed

Support all formatting flags in std::path::Display #44048

alexcrichton opened this issue Aug 22, 2017 · 3 comments
Labels
A-fmt Area: std::fmt C-feature-request Category: A feature request, i.e: not implemented / a PR. E-help-wanted Call for participation: Help is requested to fix this issue. Libs-Tracked Libs issues that are tracked on the team's project board. P-low Low priority T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@alexcrichton
Copy link
Member

This regression was initially noted in #43765 which was caused in #42613 where this struct in the standard library no longer respects all formatting flags. This is a tracking issue for supporting all formatting flags all the time, not just when it's conveniently already a &str.

@alexcrichton alexcrichton added C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. P-low Low priority regression-from-stable-to-stable Performance or correctness regression from one stable version to another. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Aug 22, 2017
@KodrAus KodrAus added A-fmt Area: std::fmt Libs-Tracked Libs issues that are tracked on the team's project board. labels Jul 31, 2020
@bstrie
Copy link
Contributor

bstrie commented Jul 3, 2021

I'd like to make a test case here but I'm unclear on what the issue is. The PR (#43830) that closed #43765 added tests for the width/fill/alignment formatting flags, and I can't think of what other flags would apply to Path. I'm also not sure what "it" refers to in the sentence "not just when it's conveniently already a &str". However, given that Alex made this issue while discussing the PR, I assume he had something in mind here, so I'm hesitant to close this outright.

@m-ou-se m-ou-se added C-feature-request Category: A feature request, i.e: not implemented / a PR. and removed regression-from-stable-to-stable Performance or correctness regression from one stable version to another. C-tracking-issue Category: A tracking issue for an RFC or an unstable feature. labels Jul 28, 2021
@yaahc yaahc added the E-help-wanted Call for participation: Help is requested to fix this issue. label Jul 28, 2021
@m-ou-se
Copy link
Member

m-ou-se commented Jul 28, 2021

Relabeling this as a feature request rather than a regression, considering four years have passed without any comments here requesting for it.

@alexcrichton Can you clarify which flags you are talking about here? See the above comment.

@alexcrichton
Copy link
Member Author

Not that I remember 2017 off the top of my head, but rereading here I believe that the issue is that Paths which are valid utf-8 follow formatting flags correctly, but paths which are not valid utf-8 may not. I suspect at the time I was sure that invalid utf-8 paths did not follow formatting flags, but I'm not sure if that's the case still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-fmt Area: std::fmt C-feature-request Category: A feature request, i.e: not implemented / a PR. E-help-wanted Call for participation: Help is requested to fix this issue. Libs-Tracked Libs issues that are tracked on the team's project board. P-low Low priority T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

6 participants