Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Searching "&" and "&mut" in stdlib api docs should show "reference (primitive)" #46075

Closed
Havvy opened this issue Nov 18, 2017 · 1 comment · Fixed by #80068 or #80159
Closed

Searching "&" and "&mut" in stdlib api docs should show "reference (primitive)" #46075

Havvy opened this issue Nov 18, 2017 · 1 comment · Fixed by #80068 or #80159
Labels
A-type-based-search Area: Searching rustdoc pages using type signatures C-feature-request Category: A feature request, i.e: not implemented / a PR. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@Havvy
Copy link
Contributor

Havvy commented Nov 18, 2017

If you don't recall or know the name of the reference primitive (like, uh, I did earlier), searching on https://doc.rust-lang.org/std/ for "&", "&m", "&mu", and "&mut" should show the result "reference (primitive)" as the first result.

Likewise for [] and [;] for slices and arrays, and () and (,) and (,,) and etc. for tuples. And probably others.
@kennytm kennytm added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. C-feature-request Category: A feature request, i.e: not implemented / a PR. labels Nov 18, 2017
@GuillaumeGomez
Copy link
Member

Like said on IRC, it'll be complicated and we'll require a strong and huge update of the search functionalities.

@jyn514 jyn514 added the A-type-based-search Area: Searching rustdoc pages using type signatures label Aug 27, 2020
This was referenced Dec 16, 2020
Merged
Merged
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Dec 19, 2020
@Dylan-DPC
Rollup merge of rust-lang#80068 - jyn514:mut-reference, r=m-ou-se
5ba1b8f 
Add `&mut` as an alias for 'reference' primitive

Closes rust-lang#46075.
@bors bors closed this as completed in dbcf659 Dec 19, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Dec 21, 2020
@Dylan-DPC
Rollup merge of rust-lang#80159 - jyn514:array, r=m-ou-se
f066f7c 
Add array search aliases

Missed this in rust-lang#80068. This one will really fix rust-lang#46075.

The last alias especially I'm a little unsure about - maybe fuzzy search should be fixed in rustdoc instead? Happy to make that change although I'd have to figure out how.

r? `@m-ou-se` although cc `@GuillaumeGomez` for the search issue.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this issue Dec 21, 2020
@Dylan-DPC
Rollup merge of rust-lang#80159 - jyn514:array, r=m-ou-se
635ea92 
Add array search aliases

Missed this in rust-lang#80068. This one will really fix rust-lang#46075.

The last alias especially I'm a little unsure about - maybe fuzzy search should be fixed in rustdoc instead? Happy to make that change although I'd have to figure out how.

r? ``@m-ou-se`` although cc ``@GuillaumeGomez`` for the search issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-type-based-search Area: Searching rustdoc pages using type signatures C-feature-request Category: A feature request, i.e: not implemented / a PR. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add &mut as an alias for 'reference' primitive jyn514/rust
Add array search aliases jyn514/rust
4 participants
@kennytm @Havvy @GuillaumeGomez @jyn514