Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnsafeCell::into_inner is safe regressions #48718

Closed
Mark-Simulacrum opened this issue Mar 4, 2018 · 3 comments
Closed

UnsafeCell::into_inner is safe regressions #48718

Mark-Simulacrum opened this issue Mar 4, 2018 · 3 comments
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta.
Milestone

Comments

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Mar 4, 2018

This is likely going to be closed as expected breakage. This means those cc-ed below should probably aim to fix their crate and release a new point release.

Caused by #47204.

Estimated breakage: 43 versions (0.05% versions); 11 crates (0.08% crates).

@Mark-Simulacrum Mark-Simulacrum added the regression-from-stable-to-beta Performance or correctness regression from stable to beta. label Mar 4, 2018
@Mark-Simulacrum Mark-Simulacrum added this to the 1.25 milestone Mar 4, 2018
@leoyvens
Copy link
Contributor

leoyvens commented Mar 4, 2018

I'm pretty sure @reem doesn't maintain things anymore.

@sfackler
Copy link
Member

sfackler commented Mar 4, 2018

Those are just lint failures so it won't prevent anyone from depending on those crates, fortunately.

@alexcrichton
Copy link
Member

I'm going to close this as we don't typically back things out due to lint changes and otherwise the impact here looks relatively small

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta.
Projects
None yet
Development

No branches or pull requests

4 participants