-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XID_Start / XID_Continue might not be quite right #4928
Comments
Bug triage. Re-nominating to change to milestone 1, well-defined. |
accepted for backwards-compatible milestone |
Non-ascii identifiers are currently feature gated, so this isn't as pressing, but we still need to figure out what to do here. Re-nominating, I don't think this needs to be backcompat. |
Correct, non-ascii idents are feature-gated. Recategorizing as P-low (and not 1.0). |
I would really like to see Unicode superscripts allowed, as subscripts already are. I would be willing to make a pull request to implement this. |
Triage: unicode identifiers are still feature gated, no changes. |
XID_Start / XID_Continue has one small bug, and is not enough to get proper unicode identifiers safe. See also http://websec.github.io/unicode-security-guide/ bug: U+3164 HANGUL FILLER and U+ffa0 are wrongly specified as ID_Continue. Disallow these. |
Closing in favor of #55467. |
@Centril, is this specific issue actually addressed in rust-lang/rfcs#2457 or tracked in #55467? As far as I can tell they specify unmodified |
@SimonSapin at least tracked in that issue to consolidate; tho I didn't read the issue description in detail. |
I’ve added this as a checkbox in Unresolved Questions in #55467 |
http://www.open-std.org/jtc1/sc22/wg14/www/docs/n1518.htm
The ISO JTC1/SC22/WG14 (C language) think that possibly UTR#31 didn't quite hit the nail on the head in terms of defining identifier syntax. They have a couple tweaks in mind. Consider following their lead.
The text was updated successfully, but these errors were encountered: