Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ./x.py errors more machine-grep-able #51385

Closed
mark-i-m opened this issue Jun 6, 2018 · 5 comments
Closed

Make ./x.py errors more machine-grep-able #51385

mark-i-m opened this issue Jun 6, 2018 · 5 comments
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@mark-i-m
Copy link
Member

mark-i-m commented Jun 6, 2018

We should systematically make all errors emitted by ./x.py more grep-able. This will make life easier for @TimNN and other bots.

@Mark-Simulacrum
Copy link
Member

Could you be more specific? What do you mean by "errors emitted by x.py"? Most of these are test failures and compiler failures... which are already quite good, generally speaking, I'd imagine.

@mark-i-m
Copy link
Member Author

mark-i-m commented Jun 6, 2018

Yes, I mostly mean compile and test failures -- anything that would fail a Travis build. Surprisingly, these are not as easy to find as one might expect, since TimNNBot often gives not-very-helpful snippets (e.g. too much or too little, such as #51335 (comment)).

Instead we should print something like "[ERROR START]" and "[ERROR END]" around the portions we want bots to pick up.

@Mark-Simulacrum
Copy link
Member

The bot isn't based on start/stop lines iirc, so I'm not sure that's the right approach. @TimNN probably knows better than me, though.

@hellow554
Copy link
Contributor

One way could be --output-format=json|xml|....
I mean, the effort to do this is quite high, but you have to decide if it's worth it.

@memoryruins memoryruins added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-feature-request Category: A feature request, i.e: not implemented / a PR. labels Sep 15, 2018
@mark-i-m
Copy link
Member Author

mark-i-m commented Apr 3, 2019

There doesn't seem to be high demand for this. Shall I close the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature-request Category: A feature request, i.e: not implemented / a PR. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

No branches or pull requests

4 participants