Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundled clippy is built with incorrect sysroot #57117

Closed
o01eg opened this issue Dec 25, 2018 · 2 comments
Closed

Bundled clippy is built with incorrect sysroot #57117

o01eg opened this issue Dec 25, 2018 · 2 comments
Labels
T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Comments

@o01eg
Copy link
Contributor

o01eg commented Dec 25, 2018

See rust-lang/rust-clippy#2874

Clippy is compiled with SYSROOT environment variable is "" while correct value should be "/usr"

config.toml:

[llvm]
optimize = true
release-debuginfo = false
assertions = false
targets = "X86;Mips;NVPTX;BPF;AArch64"
[build]
build = "x86_64-unknown-linux-gnu"
host = ["x86_64-unknown-linux-gnu"]
target = ["x86_64-unknown-linux-gnu"]
docs = false
submodules = false
python = "python2.7"
locked-deps = true
vendor = false
verbose = 2
sanitizers = false
extended = true
tools = ["clippy",]
[install]
prefix = "/usr"
libdir = "lib64/rust-9999"
docdir = "share/doc/rust-9999"
mandir = "share/rust-9999/man"
[rust]
optimize = true
debuginfo = false
debug-assertions = true # false
jemalloc = true
default-linker = "x86_64-pc-linux-gnu-gcc"
rpath = false
ignore-git = false
lld = false
llvm-tools = true
[target.x86_64-unknown-linux-gnu]
cc = "x86_64-pc-linux-gnu-gcc"
cxx = "x86_64-pc-linux-gnu-g++"
linker = "x86_64-pc-linux-gnu-gcc"
ar = "x86_64-pc-linux-gnu-ar"

OS: Gentoo Linux AMD64

@Centril Centril added the T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. label Dec 28, 2018
@flip1995
Copy link
Member

This should've been fixed here: rust-lang/rust-clippy@f5db351

It is also tested by Clippy's CI, that clippy-driver and rustc always print the same sysroot.

@o01eg
Copy link
Contributor Author

o01eg commented Sep 30, 2020

Currently clippy works without patches so I suppose this issues was fixed before.

@o01eg o01eg closed this as completed Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants