Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assertion in build on Linux x86 #6096

Closed
mzabaluev opened this issue Apr 28, 2013 · 4 comments
Closed

Assertion in build on Linux x86 #6096

mzabaluev opened this issue Apr 28, 2013 · 4 comments

Comments

@mzabaluev
Copy link
Contributor

The recent master tree fails the build on Linux (3.8.8-203.fc18.i686 #1 SMP Wed Apr 24 13:33:43 UTC 2013 i686 i686 i386 GNU/Linux) with gcc 4.7.2 20121109 (Red Hat 4.7.2-8).

rustc: /home/mzabaluev/src/rust/src/rt/rust_run_program.cpp:205: RunProgramResult rust_run_program(const char**, void*, const char*, int, int, int): Assertion `!result && "chdir failed"' failed.
/bin/sh: line 1: 20745 Segmentation fault i686-unknown-linux-gnu/stage1/bin/rustc --cfg stage1 -O --target=i686-unknown-linux-gnu -o i686-unknown-linux-gnu/stage1/lib/rustc/i686-unknown-linux-gnu/lib/libcore.so /home/mzabaluev/src/rust/src/libcore/core.rc

The failure bisects to 91aeecf.
@mzabaluev mzabaluev mentioned this issue Apr 28, 2013
Closed
@Dretch
Copy link
Contributor

Dretch commented Apr 28, 2013

@graydon suggested that the FFI can have issues when returning structs, so I guess that might somehow be causing this issue.

I am currently re-writing more of rust_run_program.cpp in rust (see #2674) ... which I should imagine will fix this issue.

@nikomatsakis
Copy link
Contributor

definitely reproducible.

@brson
Copy link
Contributor

brson commented Apr 29, 2013

This is a problem only in stage0. The FFI works correctly (in this case) after stage0. Making a snapshot would resolve this, but unfortunately incoming is still broken.

@Dretch Dretch mentioned this issue Apr 30, 2013
Merged
bors added a commit that referenced this issue May 3, 2013
@bors
auto merge of #6140 : Dretch/rust/run-with-rust, r=brson
baa1c18 
Even more of `core::run` could be rust-ified -- I believe that access to the C extern environ can be done with rust now. I did not do this because some special casing is needed for OSX and I don't have a mac I can test with.

I think this will also fix #6096.
@mzabaluev
Copy link
Contributor Author

Latest incoming builds without error. Thank you.

flip1995 pushed a commit to flip1995/rust that referenced this issue Oct 9, 2020
Allow exponent separator
e91202c 
Fixes rust-lang#6096
flip1995 pushed a commit to flip1995/rust that referenced this issue Oct 9, 2020
@bors
Auto merge of rust-lang#6104 - mikerite:fix-6096, r=ebroto
f0eac45 
Allow exponent separator

Fixes rust-lang#6096

changelog: Fixed bug in `clippy::inconsistent_digit_grouping` when floating point exponent is used
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@brson @nikomatsakis @mzabaluev @Dretch