Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rustdoc] on search results, when pressing ESC, either remove text in URL or don't remove text in search bar #63443

Closed
GuillaumeGomez opened this issue Aug 10, 2019 · 0 comments · Fixed by #64312
Closed

[rustdoc] on search results, when pressing ESC, either remove text in URL or don't remove text in search bar #63443

GuillaumeGomez opened this issue Aug 10, 2019 · 0 comments · Fixed by #64312
Assignees
@GuillaumeGomez
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@GuillaumeGomez
Copy link
Member

I think the best be the second: not removing text from search bar.
@GuillaumeGomez GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Aug 10, 2019
@GuillaumeGomez GuillaumeGomez self-assigned this Aug 10, 2019
@jonas-schievink jonas-schievink changed the title [rustdoc] on search results, when pressing ESC, either remove text in URL or don't remove text in sidebar [rustdoc] on search results, when pressing ESC, either remove text in URL or don't remove text in search bar Aug 10, 2019
@GuillaumeGomez GuillaumeGomez mentioned this issue Sep 9, 2019
Merged
@bors bors closed this as completed in f7ee130 Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Unify escape usage GuillaumeGomez/rust
1 participant
@GuillaumeGomez