Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should async/await be strict keywords? #64853

Closed
ehuss opened this issue Sep 27, 2019 · 2 comments · Fixed by #64875
Closed

Should async/await be strict keywords? #64853

ehuss opened this issue Sep 27, 2019 · 2 comments · Fixed by #64875
Assignees
@ehuss
Labels
A-async-await Area: Async & Await A-diagnostics Area: Messages for errors, warnings, and lints C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team, which will review and decide on the PR/issue.

Comments

@ehuss
Copy link
Contributor

ehuss commented Sep 27, 2019

My impression is that async and await should be strict keywords. They are currently marked as "unused" or "reserved" (unused, unstable). I think the main consequence is that in error messages it is called a reserved keyword if you try to use it as an identifier, when it should just say "keyword".
@jonas-schievink jonas-schievink added A-async-await Area: Async & Await A-diagnostics Area: Messages for errors, warnings, and lints C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team, which will review and decide on the PR/issue. labels Sep 27, 2019
@petrochenkov
Copy link
Contributor

Keywords are supposed to migrate from the "reserved-unused" category to "used" immediately after or together with their stabilization. (There are some related comments on the keyword lists in symbol.rs).
Stable async/await is already on beta, right? Then it's time to mark the keywords as "used" as well.

@ehuss
Copy link
Contributor Author

ehuss commented Sep 28, 2019

Thanks, I'll take a look at updating it.

@ehuss ehuss self-assigned this Sep 28, 2019
@ehuss ehuss mentioned this issue Sep 28, 2019
Merged
@bors bors closed this as completed in 787829d Sep 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ehuss ehuss

Labels
A-async-await Area: Async & Await A-diagnostics Area: Messages for errors, warnings, and lints C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-lang Relevant to the language team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade async/await to "used" keywords. ehuss/rust
3 participants
@ehuss @jonas-schievink @petrochenkov