Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustfmt no longer builds after rust-lang/rust#65076 #65085

Closed
rust-highfive opened this issue Oct 4, 2019 · 4 comments · Fixed by #65328
Closed

rustfmt no longer builds after rust-lang/rust#65076 #65085

rust-highfive opened this issue Oct 4, 2019 · 4 comments · Fixed by #65328
Assignees
@topecongiro
Labels
P-high High priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@rust-highfive
Copy link
Collaborator

Hello, this is your friendly neighborhood mergebot.
After merging PR #65076, I observed that the tool rustfmt no longer builds.
A follow-up PR to the repository https://github.com/rust-lang/rustfmt is needed to fix the fallout.

cc @tmandry, do you think you would have time to do the follow-up work?
If so, that would be great!

cc @tmandry, the PR reviewer, and @rust-lang/compiler -- nominating for prioritization.
@rust-highfive rust-highfive added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 4, 2019
@tesuji
Copy link
Contributor

tesuji commented Oct 4, 2019

Breakage by #64690

@topecongiro topecongiro mentioned this issue Oct 5, 2019
Merged
@ghedo
Copy link
Contributor

ghedo commented Oct 9, 2019

@topecongiro looks like rustfmt has been fixed, is there anything else blocking an update of rustfmt here? I can create the PR if you are busy :)

@topecongiro
Copy link
Contributor

@ghedo We need to update rls and rustfmt at the same time because the rustc repository forbids tools to depend on multiple rustc-ap-* crates at once. So this is blocked by #65084.

@pnkfelix
Copy link
Member

triage: P-high. Removing nomination label.

@pnkfelix pnkfelix added P-high High priority and removed I-nominated labels Oct 10, 2019
@ghedo ghedo mentioned this issue Oct 10, 2019
Merged
@Xanewok Xanewok mentioned this issue Oct 11, 2019
Closed
@tesuji tesuji mentioned this issue Oct 12, 2019
Merged
@bors bors closed this as completed in 1721c96 Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@topecongiro topecongiro

Labels
P-high High priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update rls and rustfmt tesuji/rustc
Update RLS and Rustfmt Xanewok/rust
5 participants
@ghedo @pnkfelix @rust-highfive @tesuji @topecongiro