Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A way to test differences in diagnostics between stable and nightly #65903

Open
Centril opened this issue Oct 28, 2019 · 0 comments
Open

A way to test differences in diagnostics between stable and nightly #65903

Centril opened this issue Oct 28, 2019 · 0 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@Centril
Copy link
Contributor

Centril commented Oct 28, 2019

Sometimes we do things like if self.sess.opts.unstable_features.is_nightly_build() { to switch between diagnostics for stable and nightly, e.g. as in #65893.

It would be good to have a way to tell a nightly compiler to behave as-if it was a stable one by making .is_nightly_build() return false. Ideally, this would be provided as a -Z flag which can be used in UI tests.

cc @estebank

@Centril Centril added A-testsuite Area: The testsuite used to check the correctness of rustc A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 28, 2019
@JohnTitor JohnTitor added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Apr 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-testsuite Area: The testsuite used to check the correctness of rustc C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

2 participants