Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-Zborrowck and #![feature(nll)] still exist #66494

Closed
bjorn3 opened this issue Nov 17, 2019 · 2 comments
Closed

-Zborrowck and #![feature(nll)] still exist #66494

bjorn3 opened this issue Nov 17, 2019 · 2 comments
Labels
A-driver Area: rustc_driver that ties everything together into the `rustc` compiler C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@bjorn3
Copy link
Member

bjorn3 commented Nov 17, 2019

The AST borrowck was removed in #64790, so these flags don't have a purpose anymore.

@jonas-schievink jonas-schievink added A-driver Area: rustc_driver that ties everything together into the `rustc` compiler C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 17, 2019
@bjorn3
Copy link
Member Author

bjorn3 commented Nov 17, 2019

#![feature(nll)] seems to matter to libstd somehow. When removing #![feature(nll)] it gives the following errors:

error[E0309]: the parameter type `K` may not live long enough
    --> src/libstd/collections/hash/map.rs:2435:9
     |
2427 | impl<'a, K, V, S> Extend<(&'a K, &'a V)> for HashMap<K, V, S>
     |          - help: consider adding an explicit lifetime bound `K: 'a`...
...
2435 |         self.base.extend(iter)
     |         ^^^^^^^^^^^^^^^^^^^^^^
     |
note: ...so that the reference type `&'a K` does not outlive the data it points at
    --> src/libstd/collections/hash/map.rs:2435:9
     |
2435 |         self.base.extend(iter)
     |         ^^^^^^^^^^^^^^^^^^^^^^

error[E0309]: the parameter type `V` may not live long enough
    --> src/libstd/collections/hash/map.rs:2435:9
     |
2427 | impl<'a, K, V, S> Extend<(&'a K, &'a V)> for HashMap<K, V, S>
     |             - help: consider adding an explicit lifetime bound `V: 'a`...
...
2435 |         self.base.extend(iter)
     |         ^^^^^^^^^^^^^^^^^^^^^^
     |
note: ...so that the reference type `&'a V` does not outlive the data it points at
    --> src/libstd/collections/hash/map.rs:2435:9
     |
2435 |         self.base.extend(iter)
     |         ^^^^^^^^^^^^^^^^^^^^^^

@Mark-Simulacrum
Copy link
Member

There's a separate tracking issue for this (NLL at least, and I believe @Centril noted recently there was a second one to consider). Closing since this is a duplicate; cc #58781 #57895

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-driver Area: rustc_driver that ties everything together into the `rustc` compiler C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

3 participants