Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove uses of _ in defaults #67693

Open
mark-i-m opened this issue Dec 29, 2019 · 0 comments
Open

Remove uses of _ in defaults #67693

mark-i-m opened this issue Dec 29, 2019 · 0 comments
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-cleanup Category: PRs that clean code up or issues documenting cleanup. C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@mark-i-m
Copy link
Member

Quoting myself from the referenced thread:

I feel like the internal use of _ as a default name for things is a bit undisciplined, and it's leaking into diagnostics in annoying ways. There is also this: #66679

I feel like internally, we should keep a strong separation between names that we get from the source code being compiled and names being generated by the compiler...

Originally posted by @mark-i-m in #67565 (comment)

cc @Centril @matthewjasper @pnkfelix
@Centril Centril added A-diagnostics Area: Messages for errors, warnings, and lints T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Dec 29, 2019
@fmease fmease added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-diagnostics Area: Messages for errors, warnings, and lints C-cleanup Category: PRs that clean code up or issues documenting cleanup. C-enhancement Category: An issue proposing an enhancement or a PR with one. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Centril @mark-i-m @fmease