make_ascii_lower/uppercase for Windows OsString? #69566
Labels
C-feature-request
Category: A feature request, i.e: not implemented / a PR.
O-windows
Operating system: Windows
T-libs-api
Relevant to the library API team, which will review and decide on the PR/issue.
The standard library seems to assume calling
make_ascii_uppercase()
on the underlying[u8]
is safe on Windows, seen here:rust/src/libstd/sys/windows/process.rs
Lines 35 to 41 in 0eb878d
Would it be reasonable to add a
make_ascii_uppercase()
and/ormake_ascii_lowercase()
to WindowsOsStrExt
and/orOsStringExt
to make this available to users of std?Even if the internal representation of OsString changes down the road, I would assume the code above would still need to be replicated with the new representation, so it seems like it should be okay to have
make_ascii_uppercase
a stable/public API.If this is a reasonable request, I am willing to make a PR with the appropriate methods implemented in the appropriate places.
The text was updated successfully, but these errors were encountered: