Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rustdoc] ALIASES[crate] is undefined #73620

Closed
tesuji opened this issue Jun 22, 2020 · 4 comments · Fixed by #73644
Closed

[rustdoc] ALIASES[crate] is undefined #73620

tesuji opened this issue Jun 22, 2020 · 4 comments · Fixed by #73644
Labels
C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@tesuji
Copy link
Contributor

tesuji commented Jun 22, 2020

I loaded the std doc at https://doc.rust-lang.org/nightly/std/index.html in Firefox 77.0.1,
then I typed fast for the word "true" (or click this link: https://doc.rust-lang.org/nightly/std/index.html?search=true).

I expected to see this happen: The search result appears and includes the "true" keyword link.

Instead, this happened: No search result was shown.
Also in the Firefox console, this was printed after typing the word "true":

TypeError: ALIASES[crate] is undefined 3 main1.46.0.js:formatted:869
    handleAliases main1.46.0.js:869
    execQuery main1.46.0.js:1110
    execSearch main1.46.0.js:1407
    search main1.46.0.js:1457

Meta

Version of std docs: 1.46.0-nightly (a8cf399 2020-06-21)

cc @jyn514 in case you interest.

@tesuji tesuji added the C-bug Category: This is a bug. label Jun 22, 2020
@tesuji
Copy link
Contributor Author

tesuji commented Jun 22, 2020

The type error happened along this line:

for (i = 0; i < ALIASES[crate][query.search].length; ++i) {

@jonas-schievink jonas-schievink added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jun 22, 2020
@ollie27
Copy link
Member

ollie27 commented Jun 23, 2020

It looks like it fails when you have a crate filter selected. Almost certainly caused by #71724 (cc @GuillaumeGomez).

@ollie27 ollie27 added the regression-from-stable-to-beta Performance or correctness regression from stable to beta. label Jun 23, 2020
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Jun 23, 2020
@tesuji
Copy link
Contributor Author

tesuji commented Jun 23, 2020

It looks like it fails when you have a crate filter selected

yeah, that's right. I forgot about that detail.

@ollie27
Copy link
Member

ollie27 commented Jun 23, 2020

#73644 should fix this.

@bors bors closed this as completed in ff5b446 Jun 23, 2020
@jyn514 jyn514 removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug. regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants