Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustdoc: Help dialog doesn't open when the ? key is not behind Shift #75386

Closed
runiq opened this issue Aug 11, 2020 · 1 comment · Fixed by #75393
Closed

Rustdoc: Help dialog doesn't open when the ? key is not behind Shift #75386

runiq opened this issue Aug 11, 2020 · 1 comment · Fixed by #75393
Labels
C-bug Category: This is a bug.

Comments

@runiq
Copy link

runiq commented Aug 11, 2020

I'm using a weird keyboard layout which doesn't put the ? key behind Shift, which stopped me from ever viewing the help popup in Rustdoc. If I had managed to open the help popup, I would have learned about the incredibly useful type-based search feature much sooner. 👍

As far as I can tell, the code responsible is here: It's checking for ev.shiftKey unconditionally, but I believe it's only supposed to check when ev.key is undefined.

@runiq runiq added the C-bug Category: This is a bug. label Aug 11, 2020
@GuillaumeGomez
Copy link
Member

I added a button to show the help yesterday in #75366. However, it shouldn't fail like this. Sending a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants