Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad printing of const-eval queries #75447

Closed
RalfJung opened this issue Aug 12, 2020 · 4 comments · Fixed by #75710
Closed

Bad printing of const-eval queries #75447

RalfJung opened this issue Aug 12, 2020 · 4 comments · Fixed by #75710
Assignees
Labels
A-const-eval Area: Constant evaluation (MIR interpretation) C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

Comments

@RalfJung
Copy link
Member

RalfJung commented Aug 12, 2020

Evaluating of promoteds currently looks very confusing in the query stack:

query stack during panic:
#0 [const_eval_raw] const-evaluating `main`
#1 [const_eval_validated] const-evaluating + checking `main`
#2 [const_eval_validated] const-evaluating + checking `main`
#3 [normalize_generic_arg_after_erasing_regions] normalizing `main::promoted[2]`
#4 [optimized_mir] optimizing MIR for `main`
#5 [collect_and_partition_mono_items] collect_and_partition_mono_items

main is not a const, so "const-evaluating main" is just nonsense.

I presume that this is easy to fix but only @oli-obk would know how. ;)

@RalfJung
Copy link
Member Author

Also see #75445 (comment)

@RalfJung RalfJung added E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue. A-const-eval Area: Constant evaluation (MIR interpretation) C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Aug 12, 2020
@oli-obk oli-obk added A-const-eval Area: Constant evaluation (MIR interpretation) C-cleanup Category: PRs that clean code up or issues documenting cleanup. and removed A-const-eval Area: Constant evaluation (MIR interpretation) C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Aug 12, 2020
@ThibsG
Copy link
Contributor

ThibsG commented Aug 14, 2020

Let's give a try 😉

@ThibsG
Copy link
Contributor

ThibsG commented Aug 14, 2020

@rustbot claim

@RalfJung
Copy link
Member Author

RalfJung commented Aug 14, 2020

@ThibsG awesome. :) Let us know if you need any help.

I am not very familiar with that specific code, but can still help with more general questions, and I hope @oli-obk can help with the specifics. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-const-eval Area: Constant evaluation (MIR interpretation) C-cleanup Category: PRs that clean code up or issues documenting cleanup. E-easy Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants