Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

./x.py bench builds the entire stage #76862

Closed
est31 opened this issue Sep 18, 2020 · 3 comments
Closed

./x.py bench builds the entire stage #76862

est31 opened this issue Sep 18, 2020 · 3 comments
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@est31
Copy link
Member

est31 commented Sep 18, 2020

Running ./x.py bench --stage 0 compiler/rustc_arena/ compiles the entire stage before it performs the benches instead of compiling only up to compiler/rustc_arena. This makes using the internal benchmarks for evaluating changes of rustc_arena pretty hard.
@jonas-schievink jonas-schievink added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) C-enhancement Category: An issue proposing an enhancement or a PR with one. labels Sep 18, 2020
@jonas-schievink
Copy link
Contributor

Workaround: cargo +nightly bench -p rustc_arena

@jyn514
Copy link
Member

jyn514 commented Oct 11, 2021

I think this is a duplicate of #44293.

@est31
Copy link
Member Author

est31 commented Oct 11, 2021

Indeed it is, closing in favour of that one.

@est31 est31 closed this as completed Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-enhancement Category: An issue proposing an enhancement or a PR with one. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonas-schievink @est31 @jyn514