Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression: array methods unstable feature use #78140

Closed
Mark-Simulacrum opened this issue Oct 20, 2020 · 2 comments
Closed

regression: array methods unstable feature use #78140

Mark-Simulacrum opened this issue Oct 20, 2020 · 2 comments
Labels
P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Milestone

Comments

@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Oct 20, 2020

Several crates are erroring on as_slice/as_mut_slice being added to the array types (unstably).

I suspect this is because method resolution is now seeing the method on arrays, whereas previously we derefed to &mut [T] and then there was a trait impl on that? There was another similar issue recently, but I forget what the resolution there was.

cc #76118

@Mark-Simulacrum Mark-Simulacrum added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Oct 20, 2020
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Oct 20, 2020
@Mark-Simulacrum Mark-Simulacrum added this to the 1.48.0 milestone Oct 20, 2020
@spastorino spastorino added P-high High priority and removed I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Oct 21, 2020
@camelid
Copy link
Member

camelid commented Oct 21, 2020

Relevant wg-prioritization discussion.

@eddyb
Copy link
Member

eddyb commented Nov 6, 2020

Shouldn't #48552 prevent this from being an issue at all? Do we need to extend it in some way?
cc @nikomatsakis @pnkfelix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-high High priority regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

5 participants