Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jsondocck] Add 'pretty' errors for shlex::split #81319

Closed
CraftSpider opened this issue Jan 24, 2021 · 1 comment · Fixed by #81320
Closed

[jsondocck] Add 'pretty' errors for shlex::split #81319

CraftSpider opened this issue Jan 24, 2021 · 1 comment · Fixed by #81320
Assignees
@CraftSpider
Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-rustdoc-json Area: Rustdoc JSON backend A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@CraftSpider
Copy link
Contributor

CraftSpider commented Jan 24, 2021 •
edited by rustbot
Loading

The following comment causes a panic in jsondocck currently:

// @has "foo

Expected: Pretty error like 'Invalid split pattern on line X'

Current: Giant stack trace, only obvious if you know what that line is doing.

Opening this for tracking and so I don't forget to fix it
@CraftSpider CraftSpider added the C-bug Category: This is a bug. label Jan 24, 2021
@camelid camelid added A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-rustdoc-json Area: Rustdoc JSON backend T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) A-testsuite Area: The testsuite used to check the correctness of rustc labels Jan 24, 2021
@camelid
Copy link
Member

camelid commented Jan 24, 2021

@rustbot assign @CraftSpider (since you said "so I don't forget to fix it")

@CraftSpider CraftSpider mentioned this issue Jan 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CraftSpider CraftSpider

Labels
A-contributor-roadblock Area: Makes things more difficult for new contributors to rust itself A-rustdoc-json Area: Rustdoc JSON backend A-testsuite Area: The testsuite used to check the correctness of rustc C-bug Category: This is a bug. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make bad shlex parsing a pretty error CraftSpider/rust
2 participants
@CraftSpider @camelid