Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider moving instrument-coverage-specific behavior in rustc_typeck to backend code #83429

Closed
richkadel opened this issue Mar 23, 2021 · 0 comments · Fixed by #83666
Closed

Consider moving instrument-coverage-specific behavior in rustc_typeck to backend code #83429

richkadel opened this issue Mar 23, 2021 · 0 comments · Fixed by #83666
Labels
A-code-coverage Area: Source-based code coverage (-Cinstrument-coverage)

Comments

@richkadel
Copy link
Contributor

See review comment #83307 (comment) suggesting we may want to move the -Z instrument-coverage-specific behavior from rustc_typeck to a place more relevant to LLVM and/or codegen.

rustc_typeck appears to be the most central place to apply this fix. Is there a better place, or if not, can we add one?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-code-coverage Area: Source-based code coverage (-Cinstrument-coverage)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Run LLVM coverage instrumentation passes before optimization passes Amanieu/rust
2 participants
@jonas-schievink @richkadel