Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clone_from_slice doc can be updated after specialization #84736

Closed
bluss opened this issue Apr 30, 2021 · 1 comment · Fixed by #89945
Closed

clone_from_slice doc can be updated after specialization #84736

bluss opened this issue Apr 30, 2021 · 1 comment · Fixed by #89945
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Comments

@bluss
Copy link
Member

bluss commented Apr 30, 2021 •
edited
Loading

Current clone_from_slice doc says that the user might prefer to use copy_from_slice for Copy types, but since #81854 we automatically take care of this with specialization. We can consider to clarify docs.

The most careful action would be to let the current docs stand, if we don't want to say anything about the implementation details. I would prefer to remove the sentence about copy_from_slice, or something similar.
@bluss bluss added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools labels Apr 30, 2021
@the8472
Copy link
Member

the8472 commented May 1, 2021

Do the docs currently admit any optimizations that happen through specialization? The only one that I can think of is the zero-optimization in vec!, and even that hedges with a "may be".

@JohnTitor JohnTitor mentioned this issue Oct 16, 2021
Merged
@bors bors closed this as completed in 1520fff Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-docs Area: documentation for any part of the project, including the compiler, standard library, and tools T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove a mention to copy_from_slice from clone_from_slice doc JohnTitor/rust
2 participants
@the8472 @bluss