-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recent PRs break lots of nightly builds #88878
Comments
This is allowed under RFC 1105 rules and I believe the libs team is and was aware of the conflicts that this would create when promoting an itertools method to std, it's not the first time this happened after all. Regarding #88581, I thought there was some adjustment in method resolution (#48552) that skipped unstable methods when the feature isn't activated and a stable one of the same name is in scope. Does this not work here? Or is this due to uses of |
What about notifying the most popular crates in advance and waiting a week or so next time? The issue with num-bigint seems to have been known before the merge. |
@CryZe that applies to |
This is mainly because #88548 breaks every user of |
The reason the unstable-skip didn't work is because method resolution goes in a series of steps (T, then &T, then &mut T, etc.). The way the code is written, the unstable skip only works within a single step (when the receivers are the same between the unstable method and the other method), it doesn't seem to work across steps. I'm not sure how feasible it would be to change that, I didn't see any discussion on #48552 about the potential of having different receivers. |
Closing since this is separately tracked elsewhere (e.g., in tracking issues for the respective features). |
I'm seeing most of the nightly project broken at the moment. It's either due to #88581 or due to this one:
For example it breaks every branch of every git repo that uses:
prost-derive-0.7.0/
lalrpop-0.18.1
I suspect there's a few others, but prost is used in lots of places (as is bigint).
We need to somehow be kinder to the nightly ecosystem somehow with large scale backwardly incompatible breaking changes. Do we have an idea what percentage of projects still compile with latest nightly? I think it's a heavy dip at the moment.
The text was updated successfully, but these errors were encountered: