Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implicit panic calls not collected during monomorphization #90405

Closed
nbdd0121 opened this issue Oct 29, 2021 · 1 comment · Fixed by #90406
Closed

Implicit panic calls not collected during monomorphization #90405

nbdd0121 opened this issue Oct 29, 2021 · 1 comment · Fixed by #90406
Assignees
@nbdd0121
Labels
A-codegen Area: Code generation C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@nbdd0121
Copy link
Contributor

nbdd0121 commented Oct 29, 2021 •
edited by rustbot
Loading

Implicit panic calls can be generated from Assert MIR terminator, but they are not collected during monomorphization. This means that link error will occur if the panic functions are not codegenned with core crate, e.g. when it is marked inline.

This causes breakage in rust-lang/cargo#10019 when #90273 changes the function to be inline if panic_immediate_abort is set and exposes this issue.
@nbdd0121 nbdd0121 added the C-bug Category: This is a bug. label Oct 29, 2021
@nbdd0121
Copy link
Contributor Author

@rustbot label: T-compiler A-codegen
@rustbot claim

@rustbot rustbot added A-codegen Area: Code generation T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 29, 2021
@nbdd0121 nbdd0121 mentioned this issue Oct 29, 2021
Merged
@bors bors closed this as completed in db062de Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nbdd0121 nbdd0121

Labels
A-codegen Area: Code generation C-bug Category: This is a bug. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Collect panic/panic_bounds_check during monomorphization nbdd0121/rust
2 participants
@nbdd0121 @rustbot