Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression: Rc implements RefUnwindSafe #91869

Closed
Mark-Simulacrum opened this issue Dec 13, 2021 · 1 comment
Closed

regression: Rc implements RefUnwindSafe #91869

Mark-Simulacrum opened this issue Dec 13, 2021 · 1 comment
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Milestone
1.58.0

Comments

@Mark-Simulacrum
Copy link
Member

#87467 added an impl of RefUnwindSafe to Rc, which was detected as breaking these crates:

This seems likely to be treated as acceptable breakage (the crate in this case is specifically asserting not implementing the trait), but want to confirm that.
@Mark-Simulacrum Mark-Simulacrum added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. regression-from-stable-to-beta Performance or correctness regression from stable to beta. labels Dec 13, 2021
@Mark-Simulacrum Mark-Simulacrum added this to the 1.58.0 milestone Dec 13, 2021
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Dec 13, 2021
@Mark-Simulacrum Mark-Simulacrum mentioned this issue Dec 13, 2021
Closed
@m-ou-se
Copy link
Member

m-ou-se commented Dec 15, 2021

Discussed briefly in the libs meeting. This is expected and acceptable.

@m-ou-se m-ou-se closed this as completed Dec 15, 2021
@rustbot rustbot removed the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression-from-stable-to-beta Performance or correctness regression from stable to beta. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.58.0
Development

No branches or pull requests
3 participants
@m-ou-se @Mark-Simulacrum @rustbot