Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mobile: tapping outside the sidebar should close it #92682

Closed
jsha opened this issue Jan 9, 2022 · 1 comment · Fixed by #92803
Closed

mobile: tapping outside the sidebar should close it #92682

jsha opened this issue Jan 9, 2022 · 1 comment · Fixed by #92803
Labels
A-rustdoc-ui Area: rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@jsha
Copy link
Contributor

jsha commented Jan 9, 2022

Steps to reproduce:

  1. On mobile, tap the upper-left hamburger icon to open the sidebar menu.
  2. Tap somewhere on the right side of the screen (e.g. the search bar).

Expected result:

Sidebar closes.

Actual result:

Sidebar doesn't close.

@jsha jsha added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: rustdoc UI (generated HTML) labels Jan 9, 2022
@jsha
Copy link
Contributor Author

jsha commented Jan 12, 2022

Also, relatedly: Clicking a link in the sidebar that goes to the same doc (for instance, methods on a struct page) should close the sidebar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-ui Area: rustdoc UI (generated HTML) T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant