Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T keyboard shortcut no longer functions on new docs layout #94048

Closed
ast-ral opened this issue Feb 16, 2022 · 7 comments
Closed

T keyboard shortcut no longer functions on new docs layout #94048

ast-ral opened this issue Feb 16, 2022 · 7 comments
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@ast-ral
Copy link
Contributor

ast-ral commented Feb 16, 2022

In the "?" menu in the nightly* stdlib docs, it's documented that pressing "T" should "Focus the theme picker menu", however this menu appears to no longer exist.

* specific version: 1.60.0-nightly (09cb29c64 2022-02-15)

@rustbot label P-low T-rustdoc

@rustbot
Copy link
Collaborator

rustbot commented Feb 16, 2022

Error: Label P-low can only be set by Rust team members

Please let @rust-lang/release know if you're having trouble with this bot.

@ast-ral
Copy link
Contributor Author

ast-ral commented Feb 16, 2022

@rustbot label +T-rustdoc

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Feb 16, 2022
@hellow554
Copy link
Contributor

hellow554 commented Feb 16, 2022

The "All crates" drop down has also disappeared:

Beta:
grafik

Nightly:
grafik

@rustbot modify labels: regression-from-stable-to-nightly

@rustbot rustbot added regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Feb 16, 2022
@GuillaumeGomez
Copy link
Member

The "All crates" drop down is now directly in the search result page (the PR is here).

As for the theme picking menu, it's in the settings page now. Only exception: it is displayed when browsing docs with file:/// URL (the PR is here).

@GuillaumeGomez GuillaumeGomez removed regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Feb 17, 2022
@ast-ral
Copy link
Contributor Author

ast-ral commented Feb 18, 2022

Right, I know about the theme options in the settings menu. This is just a minor gripe about the "?" menu's documentation not matching the real behavior of the "T" key. It says it should open up a theme picker menu (and it does still open the paintbrush in file:/// URLs) but on the online docs it appears to actually do nothing (presumably because the paintbrush is hidden).

@GuillaumeGomez
Copy link
Member

I'm waiting for #93097 to be merged to remove it (it should be removed in the PR directly).

@GuillaumeGomez
Copy link
Member

It was removed so it can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

No branches or pull requests

4 participants