Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for {} when array literal [] was meant #95289

Closed
estebank opened this issue Mar 24, 2022 · 1 comment · Fixed by #95293
Closed

Account for {} when array literal [] was meant #95289

estebank opened this issue Mar 24, 2022 · 1 comment · Fixed by #95293
Assignees
@compiler-errors
Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` D-newcomer-roadblock Diagnostics: Confusing error or lint; hard to understand for new users. D-papercut Diagnostics: An error or lint that needs small tweaks. P-low Low priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Comments

@estebank
Copy link
Contributor

estebank commented Mar 24, 2022 •
edited by rustbot
Loading

When incorrectly using {} for an array literal when [] should have been used with a single element, we should provide a structured suggestion as we already do when encountering multiple literals.
@estebank estebank added A-diagnostics Area: Messages for errors, warnings, and lints P-low Low priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` D-papercut Diagnostics: An error or lint that needs small tweaks. D-newcomer-roadblock Diagnostics: Confusing error or lint; hard to understand for new users. labels Mar 24, 2022
@compiler-errors
Copy link
Member

seems easy enough, @rustbot claim

@compiler-errors compiler-errors mentioned this issue Mar 25, 2022
Merged
@bors bors closed this as completed in 8f493fd Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compiler-errors compiler-errors

Labels
A-diagnostics Area: Messages for errors, warnings, and lints A-suggestion-diagnostics Area: Suggestions generated by the compiler applied by `cargo fix` D-newcomer-roadblock Diagnostics: Confusing error or lint; hard to understand for new users. D-papercut Diagnostics: An error or lint that needs small tweaks. P-low Low priority T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

suggest wrapping single-expr blocks in square brackets compiler-errors/rust
2 participants
@estebank @compiler-errors