Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc should support hyperlinking between crates #9539

Closed
alexcrichton opened this issue Sep 26, 2013 · 0 comments
Closed

rustdoc should support hyperlinking between crates #9539

alexcrichton opened this issue Sep 26, 2013 · 0 comments
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@alexcrichton
Copy link
Member

This is obviously highly desirable. This is also fairly tricky. An ideal solution would have these properties:

  • Only one person has to specify that libstd/libextra are on the web at a specific URL
  • I should be able to look at all docs without the web.
  • I should be able to hyperlink to rustpkg libs just as easily as libstd/libextra.
  • Linking across crates should have all the fancy typarams/lifetime bounds that linking intra-crate has.

I haven't quite fleshed out a good solution to this yes, so I'm opening this bug to track progress.
alexcrichton added a commit to alexcrichton/rust that referenced this issue Sep 28, 2013
@alexcrichton
rustdoc: Show type parameters on external paths
88866a4 
This removes the internal type representation of an `External` type and instead
relies on passing around DefId structures and interpreting them accordingly.

Progress on rust-lang#9539, but there's still the problem of a crate => url mapping.
@alexcrichton alexcrichton mentioned this issue Oct 2, 2013
Merged
bors added a commit that referenced this issue Oct 3, 2013
@bors
auto merge of #9691 : alexcrichton/rust/rustdoc, r=cmr
8f40641 
This slurps in the commits from #9684 as well as closing #9539.
flip1995 pushed a commit to flip1995/rust that referenced this issue Oct 6, 2022
@bors
Auto merge of rust-lang#9539 - Jarcho:ice_9445, r=flip1995
c153bd6 
Don't lint `*_interior_mutable_const` on unions due to potential ICE.

fixes rust-lang#9445
cc rust-lang#101113

This started ICE'ing sometime last month due to stricter UB checks. I'm not sure how we could check the value of a union as MIRI doesn't seem to store which field is currently active.

changelog: Don't ICE on const unions containing a `!Freeze` type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexcrichton