Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x build src/tools/miri doesn't install miri as part of the built toolchain #97762

Closed
Kixiron opened this issue Jun 5, 2022 · 7 comments · Fixed by #110365
Closed

x build src/tools/miri doesn't install miri as part of the built toolchain #97762

Kixiron opened this issue Jun 5, 2022 · 7 comments · Fixed by #110365
Assignees
@onur-ozkan
Labels
C-bug Category: This is a bug. E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Comments

@Kixiron
Copy link
Member

Kixiron commented Jun 5, 2022 •
edited by rustbot
Loading

Running x build src/tools/miri doesn't include miri as part of the built rust toolchain, meaning that cargo +custom-toolchain miri doesn't work

cc @jyn514
@Kixiron Kixiron added the C-bug Category: This is a bug. label Jun 5, 2022
@Kixiron
Copy link
Member Author

Kixiron commented Jun 5, 2022

@rustbot label +A-rustbuild

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Jun 5, 2022
@jyn514 jyn514 mentioned this issue Jun 18, 2022
Merged
@WaffleLapkin
Copy link
Member

It seems like the same thing happens to rustfmt: x b rustfmt doesn't include rustfmt as part of the built rust toolchain, meaning that rustfmt +custom-toolchain doesn't work.

@daxpedda
Copy link
Contributor

The same thing applies to cargo and clippy.

@jyn514
Copy link
Member

jyn514 commented Jul 23, 2022 •
edited
Loading

We need to call add_to_sysroot in all of these steps. I think that currently adds all libraries as well which isn't correct - someone should look into how this is done for rustdoc and do the same for the other tools. Take a look around src/bootstrap/compile.rs.

I agree it's a bug that we don't copy these today.

@jyn514 jyn514 added E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. labels Jul 23, 2022
@WaffleLapkin
Copy link
Member

@rustbot claim

@WaffleLapkin WaffleLapkin mentioned this issue Sep 19, 2022
Closed
3 tasks
@Emilgardis
Copy link
Contributor

this seems related to #81431

@onur-ozkan
Copy link
Member

@rustbot claim

@rustbot rustbot assigned onur-ozkan and unassigned WaffleLapkin Apr 11, 2023
@onur-ozkan onur-ozkan mentioned this issue Apr 20, 2023
Merged
@bors bors closed this as completed in f2321ec Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@onur-ozkan onur-ozkan

Labels
C-bug Category: This is a bug. E-help-wanted Call for participation: Help is requested to fix this issue. E-medium Call for participation: Medium difficulty. Experience needed to fix: Intermediate. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ship tools with sysroot onur-ozkan/rust
Add tools to sysroot after build. WaffleLapkin/rust
7 participants
@Emilgardis @daxpedda @jyn514 @Kixiron @WaffleLapkin @onur-ozkan @rustbot