Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecation note and doc(cfg) don't look good in combination #98343

Closed
jplatte opened this issue Jun 21, 2022 · 1 comment · Fixed by #99779
Closed

Deprecation note and doc(cfg) don't look good in combination #98343

jplatte opened this issue Jun 21, 2022 · 1 comment · Fixed by #99779
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) F-doc_cfg `#![feature(doc_cfg)]` T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Comments

@jplatte
Copy link
Contributor

jplatte commented Jun 21, 2022 •
edited
Loading

I think there should be some spacing in between, and the different height is also unfortunate.

Screenshot_2022-06-21_155629

I also opened #98341 about the poor contrast of the link, but that's unrelated to doc(cfg).

@rustbot labels: +T-rustdoc +F-doc_cfg +A-rustdoc-ui
@rustbot rustbot added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. F-doc_cfg `#![feature(doc_cfg)]` A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Jun 21, 2022
@jsha
Copy link
Contributor

jsha commented Jul 5, 2022

Thanks for the report! Also mentioned in #98266.

@GuillaumeGomez GuillaumeGomez mentioned this issue Jul 26, 2022
Merged
@bors bors closed this as completed in 9690852 Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) F-doc_cfg `#![feature(doc_cfg)]` T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix item info pos and height GuillaumeGomez/rust
3 participants
@jsha @jplatte @rustbot