Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore gitignored files in tidy's file counting #98797

Open
thomcc opened this issue Jul 2, 2022 · 1 comment
Open

Ignore gitignored files in tidy's file counting #98797

thomcc opened this issue Jul 2, 2022 · 1 comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-feature-request Category: A feature request, i.e: not implemented / a PR.

Comments

@thomcc
Copy link
Member

thomcc commented Jul 2, 2022

Recently I apparently ended up with a .DS_Store file inside src/test/ui. This caused ./x.py test tidy to complain about:

tidy error: following path contains more than 968 entries, you should move the test to some relevant subdirectory (current: 969): /Users/thom/src/rust/src/test/ui

This would be reasonable, however I have these files globally gitignored. @jyn514 suggested that maybe it would be good if tidy didn't complain about gitignored files, and asked me to file an issue. This is that issue.

Forgive the imprecise title, I have no idea what this tidy test is trying to verify (and probably wouldn't file this issue were it not for the request -- It's not unreasonable for me to require stuff like .DS_Store not be present). I also don't know what the right label for tidy is.

@Dylan-DPC Dylan-DPC added the C-feature-request Category: A feature request, i.e: not implemented / a PR. label Jul 2, 2022
@jyn514
Copy link
Member

jyn514 commented Jul 10, 2022

cc #98793 (review), we've been meaning to do this for a while

@jyn514 jyn514 added the A-testsuite Area: The testsuite used to check the correctness of rustc label Jul 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc C-feature-request Category: A feature request, i.e: not implemented / a PR.
Projects
None yet
Development

No branches or pull requests

3 participants