FilesTimes support does not build for ESP-IDF #100119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
joshtriplett
reviewed
Aug 3, 2022
|
@ivmarkov r=me with the suggestion applied. |
rustbot
added
the
T-libs
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Aug 3, 2022
FilesTimes support does not build for ESP-IDF Commit rust-lang@1f5d8d4 broke STD for `target_os = "espidf"`. In future, we might come up with something more sophisticated (as in using the `utime` function which *is* available on the ESP-IDF platform), but for now we are treating ESP-IDF just like `Redox` in that the new API fails at runtime. Most important for us ATM is to restore successful compilation of STD on our platform.
This was referenced Aug 3, 2022
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 4, 2022
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#98877 (Set llvm configs when building lld) - rust-lang#100068 (Fix backwards-compatibility check for tests with `+whole-archive`) - rust-lang#100083 (rustdoc: use a more compact encoding for source-files.js) - rust-lang#100102 (Fix typo) - rust-lang#100104 (Remove more Clean trait implementations) - rust-lang#100105 (Add regression test for rust-lang#90871) - rust-lang#100107 (fix trailing whitespace in error message) - rust-lang#100111 (Provide suggestion on missing `let` in binding statement) - rust-lang#100119 (FilesTimes support does not build for ESP-IDF) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1f5d8d4 broke STD for
target_os = "espidf".In future, we might come up with something more sophisticated (as in using the
utimefunction which is available on the ESP-IDF platform), but for now we are treating ESP-IDF just likeRedoxin that the new API fails at runtime. Most important for us ATM is to restore successful compilation of STD on our platform.