Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollup of 6 pull requests #113049

Merged
merged 17 commits into from
Jun 26, 2023
Merged

Rollup of 6 pull requests #113049

merged 17 commits into from
Jun 26, 2023

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

he32 and others added 17 commits May 7, 2023 18:35
@he32
Add support for NetBSD/aarch64-be (big-endian arm64).
6ef377c
@he32
platform-support.md: document the various NetBSD targets.
0a1e42e 
This is slightly patterned after what OpenBSD has done.

This is a step along the path to reduce the number and amount
of diffs that pkgsrc carries around for rust, and this documents
also some parts which have not yet been upstreamed (mipsel-*).
@SergioGasquez
docs: 📝 Add missing targets
c0aed70
@heiher
doc: loongarch: Update maintainers
7609226
@wesleywiser
Remove extra trailing newline
da05ed3
@Kobzol
Cancel in-progress workflow runs after a push
3c2b8b0
@NotStirred
Add translatable diagnostic for import resolution strings
b7d6032 
Add translatable diagnostic for cannot be reexported error
also added for subdiagnostics

Add translatable diagnostics for resolve_glob_import errors

Add translatable diag for unable to determine import resolution

Add translatable diag for is not directly importable
@Kobzol
Remove cancel-outdated action
e8973ea
@jyn514
Switch some more Steps to builder.msg
bd36f63 
In particular, this hides compiletest suites under a dropdown - some builders are configured with `verbose-tests`, which makes the suites take up many thousands of lines.

before:
```
Documenting stage1 cargo (x86_64-unknown-linux-gnu)
Check compiletest suite=rustdoc-js mode=js-doc-test (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
```

after:
```
::group::Documenting stage1 cargo (x86_64-unknown-linux-gnu)
::group::Testing stage1 compiletest suite=rustdoc-js mode=js-doc-test (x86_64-unknown-linux-gnu)
```
@he32
SUMMARY.md: add entry for NetBSD.
7a07ffd
@he32
platform-support.md: remove references to not-yet upstreamed targets.
abb4395
@matthiaskrgr
Rollup merge of rust-lang#111326 - he32:netbsd-aarch64-be, r=oli-obk
f6d58ea 
Add support for NetBSD/aarch64-be (big-endian arm64).
@matthiaskrgr
Rollup merge of rust-lang#112559 - SergioGasquez:master, r=JohnTitor
ac84b66 
Add esp-idf missing targets

Adds some esp-idf missing targets to the table
@matthiaskrgr
Rollup merge of rust-lang#112840 - loongarch-rs:update-docs, r=Guilla…
de79f51 
…umeGomez

doc: loongarch: Update maintainers

My colleague, `@zhaixiaojuan,` has been completely occupied with other matters and is no longer in charge of Rust. Consequently, I intend to update the maintainers in the platform documentation to avoid causing any disruptions for her and to ensure that relevant notifications regarding LoongArch are promptly directed to the appropriate developers.

Thanks your for contributions!
@matthiaskrgr
Rollup merge of rust-lang#112955 - Kobzol:ci-pr-cancel-workflows, r=M…
5d9935a 
…ark-Simulacrum

CI: cancel in-progress workflow runs after a push

Experimenting with the `concurrency` attribute.

r? `@Mark-Simulacrum`
@matthiaskrgr
Rollup merge of rust-lang#112979 - NotStirred:translatable_diag/resol…
005d860 
…ve_imports, r=fee1-dead

Rewrite most diagnostics as translatable within resolve/imports
@matthiaskrgr
Rollup merge of rust-lang#113034 - jyn514:ci-progress, r=oli-obk
5122e88 
Switch some more Steps to `builder.msg`

In particular, this hides compiletest suites under a dropdown - some builders are configured with `verbose-tests`, which makes the suites take up many thousands of lines.

before:
```
Documenting stage1 cargo (x86_64-unknown-linux-gnu)
Check compiletest suite=rustdoc-js mode=js-doc-test (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
```

after:
```
::group::Documenting stage1 cargo (x86_64-unknown-linux-gnu)
::group::Testing stage1 compiletest suite=rustdoc-js mode=js-doc-test (x86_64-unknown-linux-gnu)
```

found this from https://github.com/rust-lang-ci/rust/actions/runs/5366993848/jobs/9736792611

r? `@oli-obk`
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jun 26, 2023
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=6

@bors
Copy link
Contributor

bors commented Jun 26, 2023

📌 Commit 5122e88 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2023
@bors
Copy link
Contributor

bors commented Jun 26, 2023

⌛ Testing commit 5122e88 with merge 27e10c5...

@bors
Copy link
Contributor

bors commented Jun 26, 2023

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 27e10c5 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 26, 2023
@bors bors merged commit 27e10c5 into rust-lang:master Jun 26, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 26, 2023
@rust-timer
Copy link
Collaborator

rust-timer commented Jun 26, 2023 •
edited by lqd
Loading

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#111326 Add support for NetBSD/aarch64-be (big-endian arm64). 77de6a4c214195b569d9817971c79500a5e77732 (link)
#112559 Add esp-idf missing targets bae6fc28cef7e2a1af7ae130fb134690b4d7e85d (link)
#112840 doc: loongarch: Update maintainers eac5d8bd14e1c5bea55205a2a4f13d5e03f063ee (link)
#112955 CI: cancel in-progress workflow runs after a push d960806ff8757f8d5136620ce40ee97713f54d97 (link)
#112979 Rewrite most diagnostics as translatable within resolve/imp… c0f4d2ced02ae3dfbf51e0ce9f530dda1a1053a3 (link)
#113034 Switch some more Steps to builder.msg c93797a87085168b462696cfa1000bcf00af1a51 (link)

previous master: 25b5af1b3a

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@Kobzol Kobzol mentioned this pull request Jun 26, 2023
Merged
@bors bors mentioned this pull request Jun 26, 2023
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (27e10c5): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 -0.8% [-1.2%, -0.5%] 17
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) -0.8% [-1.2%, -0.5%] 17

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 1.4% [1.4%, 1.4%] 1
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.8% [-3.8%, -3.8%] 1
All ❌✅ (primary) 1.4% [1.4%, 1.4%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 661.549s -> 662.166s (0.09%)

@matthiaskrgr matthiaskrgr deleted the rollup-41wo5w8 branch March 16, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.