Fix ICE on const of nullable enum with fields in null case. #11441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That is, if you have an enum type that is subject to the nullable pointer optimization, but the null variant has a nonzero number of fields, and you declare a static whose value is of that variant, then that used to be an ICE but this change fixes it.
bors
added a commit
that referenced
this pull request
Jan 10, 2014
… r=alexcrichton That is, if you have an enum type that is subject to the nullable pointer optimization, but the null variant has a nonzero number of fields, and you declare a static whose value is of that variant, then that used to be an ICE but this change fixes it.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Aug 8, 2024
`single_match`: fix checking of explicitly matched enums fixes rust-lang#11365 This approach has false-negatives, but fixing them will require a significant amount of additional state tracking. The comment in `add_and_pats` has the explanation. changelog: `single_match`: correct checking if the match explicitly matches all of an enum's variants.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That is, if you have an enum type that is subject to the nullable
pointer optimization, but the null variant has a nonzero number of
fields, and you declare a static whose value is of that variant, then
that used to be an ICE but this change fixes it.