Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand mem::offset_of! docs #117512

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Expand mem::offset_of! docs #117512

merged 4 commits into from
Nov 2, 2023

Conversation

joshlf
Copy link
Contributor

@joshlf joshlf commented Nov 2, 2023

Makes progress on #106655

@rustbot
Copy link
Collaborator

rustbot commented Nov 2, 2023

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 2, 2023
@joshlf
Copy link
Contributor Author

joshlf commented Nov 2, 2023

This is intended to address #106655 (comment).

@BurntSushi, let me know if there are any other topics you'd like me to cover.

@rust-log-analyzer

This comment has been minimized.

library/core/src/mem/mod.rs Outdated Show resolved Hide resolved
@rust-log-analyzer

This comment has been minimized.

@BurntSushi
Copy link
Member

Nice, thank you @joshlf! Looks like a big improvement. :-)

Copy link
Member

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay
Copy link
Member

dtolnay commented Nov 2, 2023

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 2, 2023

📌 Commit 2cc92e6 has been approved by dtolnay

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 2, 2023
@dtolnay dtolnay assigned dtolnay and unassigned joshtriplett Nov 2, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 2, 2023
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#117394 (use global cache when computing proof trees)
 - rust-lang#117495 (Clarify `Unsize` documentation)
 - rust-lang#117509 (Remove support for alias `-Z symbol-mangling-version`)
 - rust-lang#117512 (Expand mem::offset_of! docs)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6268598 into rust-lang:master Nov 2, 2023
11 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 2, 2023
Rollup merge of rust-lang#117512 - joshlf:patch-8, r=dtolnay

Expand mem::offset_of! docs

Makes progress on rust-lang#106655
@rustbot rustbot added this to the 1.75.0 milestone Nov 2, 2023
bors-ferrocene bot added a commit to ferrocene/ferrocene that referenced this pull request Nov 3, 2023
82: Automated pull from upstream `master` r=tshepang a=github-actions[bot]


This PR pulls the following changes from the upstream repository:

* rust-lang/rust#117313
* rust-lang/rust#117131
* rust-lang/rust#117134
* rust-lang/rust#117471
* rust-lang/rust#117521
* rust-lang/rust#117513
  * rust-lang/rust#117512
  * rust-lang/rust#117509
  * rust-lang/rust#117495
  * rust-lang/rust#117394
* rust-lang/rust#117466
* rust-lang/rust#117204
* rust-lang/rust#117386
* rust-lang/rust#117506



Co-authored-by: Nicholas Nethercote <n.nethercote@gmail.com>
Co-authored-by: roblabla <unfiltered@roblab.la>
Co-authored-by: Michael Goulet <michael@errs.io>
Co-authored-by: massivebird <gdrakemail@gmail.com>
Co-authored-by: bors <bors@rust-lang.org>
Co-authored-by: Zalathar <Zalathar@users.noreply.github.com>
Co-authored-by: lcnr <rust@lcnr.de>
Co-authored-by: Joshua Liebow-Feeser <joshlf@users.noreply.github.com>
Co-authored-by: Matthias Krüger <matthias.krueger@famsik.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants