Test & remove an obsolete syntax error #11966
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is has been obsolete for quite a while now (including a release), so removing the special handling seems fine. (The error message is quite good still anyway.) Fixes rust-lang#9580.
This was referenced Feb 1, 2014
| fn start(argc: int, argv: **u8, crate_map: *u8) -> int { | ||
| //~^ ERROR start function expects type: `fn(int, **u8) -> int` | ||
| 0 | ||
| } |
There was a problem hiding this comment.
This test appears to be completely unrelated.
There was a problem hiding this comment.
Ok, I see you did intend to include it based on the comment from #9575. I just wasn't expecting it given the PR title.
There was a problem hiding this comment.
Sorry; the title was meant to be parsed as (add a test) & (remove an obsolete syntax error).
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Dec 28, 2023
…Jarcho Do not lint `assertions_on_constants` for `const _: () = assert!(expr)` Fixes rust-lang#8159 ```rust pub fn f() { // warning assert!(true); assert!(usize::BITS >= 32); // ok const _: () = assert!(usize::BITS >= 32); } ``` changelog: Fix `const _: () = assert!(expr)` false positive on `assertions_on_constants` lint
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 11, 2024
- remove now dead code in ASSERTIONS_ON_CONSTANTS cc rust-lang#11966 - Partially revert "ignore `assertions-on-constants` in const contexts" This reverts commit c7074de420a2192fb40d3f2194a20dd0d1b65cc6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.