Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic backtrace functionality #12052

Closed
wants to merge 1 commit into from

Conversation

alexcrichton
Copy link
Member

Whenever a failure happens, if a program is run with
RUST_LOG=std::rt::backtrace a backtrace will be printed to the task's stderr
handle.

Currently this is not an exported interface because it's only supported on
osx/linux. I found that windows/freebsd/android all required extra libraries
which are not necessarily present by default.

cc #10128

Whenever a failure happens, if a program is run with
`RUST_LOG=std::rt::backtrace` a backtrace will be printed to the task's stderr
handle.

Currently this is not an exported interface because it's only supported on
osx/linux. I found that windows/freebsd/android all required extra libraries
which are not necessarily present by default.

cc rust-lang#10128
@alexcrichton
Copy link
Member Author

This may end up not being that useful for a variety of reasons:

  • Windows/android/freebsd are all currently getting thrown under the bus
  • I couldn't get a stack trace on OSX with green threads (native threads worked ok)

That being said, when you need a backtrace you often really need a backtrace, so perhaps this is useful functionality to include regardless? It's all off by default and completely unreachable outside of std::rt for now as a result of the above limitations.

@brson
Copy link
Contributor

brson commented Feb 6, 2014

I'm OK with this but I do hope somebody still adds nice cross-platform back traces based on libunwind.

@alexcrichton
Copy link
Member Author

Aha, I have discovered _Unwind_Backtrace. I will investigate this and come back with an update.

bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 25, 2022
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jan 11, 2024
…onditional_recursion, r=xFrednet

Fix false positive `unconditional_recursion`

Fixes rust-lang#12052.

Only checking if both variables are `local` was not enough, we also need to confirm they have the same type as `Self`.

changelog: Fix false positive for `unconditional_recursion` lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants