-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ffi_unwind_calls: treat RustIntrinsic like regular Rust calls #121548
Conversation
Failed to set assignee to
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
r? @BatmanAoD then maybe? |
Failed to set assignee to
|
Ah, sorry, I thought someone must have made you reviewer by now oops. |
I don't actually know very much at all about rustc internals, and haven't read much of the code. |
This comment was marked as resolved.
This comment was marked as resolved.
4280b36
to
54d024e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me with typo fix
54d024e
to
f5c80dc
Compare
@bors r=davidtwco |
☀️ Test successful - checks-actions |
Finished benchmarking commit (b6e4299): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 650.65s -> 650.523s (-0.02%) |
Also add some comments to
abi_can_unwind
to explain what happens.r? @nbdd0121 Cc @BatmanAoD