Move fourcc to HOST_CRATES #12159
Merged
Move fourcc to HOST_CRATES #12159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It depends on libsyntax, which is a host crate, so it can't be in the target crates section.
bors
added a commit
that referenced
this pull request
Feb 11, 2014
It depends on libsyntax, which is a host crate, so it can't be in the target crates section.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 25, 2022
internal: Lift out macro bang property from completion PathKind enum
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jan 25, 2024
[`default_numeric_fallback`]: improve const context detection Fixes rust-lang#12159 The lint didn't actually recognize any of the associated consts (in the linked issue), because in those cases the parent is an `ImplItem` and not an `Item`, but it only actually emitted a lint for i32 and f64 because the other cases failed the very last check here https://github.com/rust-lang/rust-clippy/blob/bb2d4973648b1af18d7ba6a3028ed7c92fde07fb/clippy_lints/src/default_numeric_fallback.rs#L91-L96 A better check for detecting constness would be using `body_const_context`, which is what this PR does. changelog: [`default_numeric_fallback`]: recognize associated consts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It depends on libsyntax, which is a host crate, so it can't be in the target
crates section.