-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix race between block initialization and receiver disconnection #121646
Conversation
r? @ChrisDenton rustbot has assigned @ChrisDenton. Use r? to explicitly pick a reviewer |
The queue looks relatively light (once the current rollup is done) so I'll boost this one to the top @bors r+ p=1 |
Needs beta backport? |
☀️ Test successful - checks-actions |
Finished benchmarking commit (fc3800f): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 650.626s -> 651.881s (0.19%) |
We don't usually backport fixes for non-critical bugs that have already been around for a while on stable. |
We briefly discussed this in the libs team meeting. We didn't have consenesus on backporting this, due to the bug already being around for a long time on stable and the low severity of the bug (a memory leak). |
The race occurs if the receiver half of an empty channel is dropped while a sender is trying to send, which is not very likely. I don't think this needs to be backported. |
Document potential memory leak in unbounded channel Follow up on rust-lang#121646.
Document potential memory leak in unbounded channel Follow up on rust-lang#121646.
Rollup merge of rust-lang#121778 - ibraheemdev:patch-19, r=RalfJung Document potential memory leak in unbounded channel Follow up on rust-lang#121646.
Port of crossbeam-rs/crossbeam#1084. Closes #121582.